cyberark / conjur-authn-k8s-client

Authentication sidecar for Conjur Kubernetes integration.
https://www.conjur.org
Apache License 2.0
11 stars 14 forks source link

The app deploy Helm chart supports deployment of app + Secrets Provider standalone container #273

Closed diverdane closed 3 years ago

diverdane commented 3 years ago

Is your feature request related to a problem? Please describe.

Issue #238 creates an initial Helm chart and Helm subchart for deploying an application/Summon + authn-k8s sidecar container.

This issue expands on the application deployment main Helm chart by adding a subchart to deploy an application that can make use of a Secrets Provider running as a standalone container.

NOTE: This issue covers only Helm chart implementation. It does not include modification of the app deploy scripts to use this new Helm chart. The modification of the app deploy scripts will be covered in Issue #292. It's entirely possible that it's easier to handle both this issue (Issue #273) and the scripting issue (Issue #292) with a single PR.

This issue will involve using two Helm charts:

  1. A new Helm subchart to deploy just the sample application with Summon
  2. An existing Secrets Provider Helm chart for deploying the SP as standalone Kubernetes Job (See https://github.com/cyberark/secrets-provider-for-k8s/tree/main/helm/secrets-provider).

There are a couple of options for how to include the existing Secrets Provider Helm chart:

Describe the solution you would like

Describe alternatives you have considered

Additional context

Out of Scope

DoD

izgeri commented 3 years ago

@diverdane is this needed? standalone secrets provider already has a helm chart for deploying - see here

diverdane commented 3 years ago

@izgeri ,

Good question! There are 2 pieces that we need to deploy for this task:

The plan is to use the Secrets Provider Helm chart as-is for the first bullet, as you suggested, and to add a subchart to the app deploy Helm chart to do the corresponding sample app (Pet Store) installation.

Cheers! Dane