Refactor and expand integration tests - Githubissues

cyberark / conjur-cli-go

CyberArk Conjur command line interface (Go)

Apache License 2.0

4 stars 2 forks source link

Refactor and expand integration tests #136

Closed szh closed 1 year ago

szh commented 1 year ago

Desired Outcome

Refactor and expand integration tests. There should be tests for all commands and options.

Implemented Changes

Refactored integration tests to allow better segmenting of tests by command
Added integration tests for all commands and options.

Connected Issue/Story

CyberArk internal issue ID: CNJR-473

Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[x] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[x] There are no security aspects to these changes

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 5bd08e03 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2
Style	1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.3% (0.0% change).

View more on Code Climate.