search

cyberark / conjur-credentials-plugin

Conjur plugin for securely providing credentials to Jenkins jobs
Apache License 2.0
12 stars 24 forks source link

automated tests exist and are run by a Jenkins build job #3

Open apotterri opened 5 years ago

apotterri commented 5 years ago

To demonstrate that the code functions as expected, and to prevent future regressions, there should be a suite of automated test for the plugin. src/test/java/org/conjur/jenkins/configuration/ConjurConfigurationTest.java exists, but the body of the test method is commented out.

As part of writing the test suite, a Jenkinsfile should be added that runs the suite and builds the .hpi when the tests all pass.

AndrewCopeland commented 4 years ago

We do have E2E tests within a separate private repo. However I do agree that more effort regarding unit tests will most likely improve quality.

I think this issue should be remain open.