cyberark / conjur-inspect

Apache License 2.0
3 stars 0 forks source link

Improve debug logging for command execution #31

Closed micahlee closed 1 year ago

micahlee commented 1 year ago

Desired Outcome

The desired outcome of this PR is to make it easier to troubleshoot failed shell commands by adding better error log output.

Implemented Changes

This PR adds better logging around shell command execution so that it's easier to view what command the inspection tool attempted to run. For fio commands, we also log the stderr output when the command returns a non-zero exit code.

Connected Issue/Story

CyberArk internal issue ID: CNJR-1071

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 5441d6e3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.6% (0.0% change).

View more on Code Climate.