cyberark / conjur-oss-helm-chart

Helm chart for deploying Conjur OSS to Kubernetes
Apache License 2.0
28 stars 24 forks source link

check for CONJUR_NAMESPACE_NAME #161

Closed rpothier closed 3 years ago

rpothier commented 3 years ago

The environmental variable CONJUR_NAMESPACE was changed to CONJUR_NAMESPACE_NAME in conjur-authn-k8s-client.

Desired Outcome

If someone sets CONJUR_NAMESPACE_NAME, that value should be used.

Implemented Changes

The there is an equivalent environmental variable to CONJUR_NAMESPACE in other projects called CONJUR_NAMESPACE_NAME. The purpose is to set the Conjur OSS namespace name in both cases. We need to check if either one exists when setting CONJUR_NAMESPACE. If both CONJUR_NAMESPACE and CONJUR_NAMESPACE_NAME are set we assume that CONJUR_NAMESPACE_NAME is the preferred name and will use that.

Connected Issue/Story

Resolves #N/A

CyberArk internal issue link: [insert issue ID]()

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security