cyberark / conjur-oss-helm-chart

Helm chart for deploying Conjur OSS to Kubernetes
Apache License 2.0
28 stars 24 forks source link

Do not add unique id to service name #163

Closed rpothier closed 3 years ago

rpothier commented 3 years ago

In conjur-oss-helm-chart the release name defaults to conjur-oss and with that is the service name. Now in conjur-authn-k8s-client the release name has a unique id that is passed into conjur-oss-helm-chart. This change will keep the service name to conjur-oss regardless of the release name, which is how conjur-oss-helm-chart was running previously as it does not use the unique id.

Desired Outcome

oc get service NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE conjur-oss NodePort 172.30.161.87 443:32333/TCP 43h

Implemented Changes

The service name will default to the fullnameOverride

Connected Issue/Story

Works towards App deployment on Openshift

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security