Open dan-transmit opened 1 year ago
Writing a test would mean to create a whole new setup (it's not like the current script has a reusable interface).
If you think that dataKeySecretRef
should be the preferred usage, then I can replace dataKey
from the tests with it.
That's true. Ideally we'd refactor the tests to make it easier to have multiple test cases. If this isn't something you're interested in doing I totally understand, we just can't merge it without tests. I'm fine to put this on hold for a bit until we can do that internally if that's ok with you.
Desired Outcome
The secret doesn't show in the helm values
Implemented Changes
Allow to use existing secrets in the cluster
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue ID: [insert issue ID]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be merged.
Changelog
Test coverage
Documentation
README
s) were updated in this PRBehavior
Security