cyberark / conjur-oss-helm-chart

Helm chart for deploying Conjur OSS to Kubernetes
Apache License 2.0
28 stars 24 forks source link

Add resource values for nginx and postgres #186

Open davejab opened 1 year ago

davejab commented 1 year ago

Desired Outcome

Expose chart values to set resource requests and limits on nginx + postgres pods.

Implemented Changes

Resource value configuration has been exposed allowing users to customise requests + limits for nginx + postgres pods. This was a requirement for our cluster as we have strict policies in place that require all pods to have resources defined.

Connected Issue/Story

n/a

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

szh commented 1 year ago

Hi @davejab,

Thank you for submitting this PR. It looks great but we need to have a test case before we can merge it. We're currently evaluating how to refactor our tests in this repository so we can easily add test cases. In the meantime I'll leave this PR open and we'll get back to it once we rework the tests.