Auto create should depend on account.create and upgrades should still work

[diverdane]

Summary

If a Conjur cluster is created with the chart setting account.name explicitly being set (i.e. not defaulted), then a couple of issues are seen:

1. The Conjur account gets created regardless of the value of account.create.
2. If this is followed up with a Helm upgrade, and account.name is not set to an empty string, then the Conjur server continually crashes with:

   Account 'myConjurAccount' already exists
   error: exit

Steps to Reproduce

Steps to reproduce the behavior:

1. Create a chart with --set account.name=foobar --set account.create=false
2. Observe that account gets created, even though account.create was set to false.
3. Do a Helm upgrade, e.g.:

   helm upgrade -n conjur-oss --reuse-values --recreate-pods conjur-oss ./conjur-oss

   and observe that the Conjur server container continually crashes.

Expected Results

• Account creation should depend upon value of account.create.
• Help upgrades should work when an account is already created even if --reuse-values is used (idempotency).

Actual Results (including error logs, if applicable)

See above.

Reproducible

• [x] Always
• [ ] Sometimes
• [ ] Non-Reproducible

Version/Tag number

Latest

Environment setup

KinD, but it shouldn't matter.

Additional Information

Explicitly setting --set account.name="" might be a workaround for Helm upgrades.