Parameterized local Docker registry name and port as env vars just in
case someone has a conflict.
If KinD cluster is already running, and USE_DOCKER_LOCAL_REGISTRY is
set to 'true', check that the registry is already running, or else
exit with an error that the KinD cluster needs to be recreated.
Delete instances of '--recreate-pods' flag.
Deleted this export in 1_create_kind_cluster since it shouldn't have
any effect (it's not sourced by the parent start script):
export DOCKER_REGISTRY_URL="${reg_ip}:${reg_port}"
Updated some comments re. use of local Docker registry in example's
README.md and in some scripts.
What does this PR do?
What's changed? Why were these changes made?
How should the reviewer approach this PR, especially if manual tests are required?
Are there relevant screenshots you can add to the PR description?
What ticket does this PR close?
Resolves #[relevant GitHub issues, eg 76]
Checklists
Change log
[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update
Test coverage
[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests
Documentation
[x] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[ ] This PR does not require updating any documentation
startscript): export DOCKER_REGISTRY_URL="${reg_ip}:${reg_port}"What does this PR do?
What ticket does this PR close?
Resolves #[relevant GitHub issues, eg 76]
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or