search

cyberark / conjur-policy-parser

Parser library for Conjur Policy YAML
MIT License
0 stars 1 forks source link

22 add types to relativepathresolver #23

Closed h-artzi closed 4 years ago

h-artzi commented 4 years ago

Issue: https://github.com/cyberark/conjur-policy-parser/issues/22

I was unsure regarding the relative paths for members in revoke and grant statements. It seems that members either have a role.id or an id. So currently, I transform both of those into relative paths. (Not sure if that was the right decision)

The next step is to bump the version!

micahlee commented 4 years ago

We should add tests cases for grant/revoke and permit/deny with absolute and relative paths in the test fixtures: https://github.com/cyberark/conjur-policy-parser/tree/master/spec/resolver-fixtures

There should at least be test case that would fail without this before making the change.

h-artzi commented 4 years ago

Yes, I will add a test case. This PR was put on hold until I update master to match the current tag (v3.0.4)