cyberark / conjur-puppet

Official Puppet module for CyberArk Conjur
https://forge.puppet.com/cyberark/conjur
Apache License 2.0
6 stars 3 forks source link

Fix broken build (`rspec-puppet` upstream bug) #132

Closed sgnn7 closed 4 years ago

sgnn7 commented 4 years ago

Summary

puppet gem released a new version of their gem which broke integration with upstream rspec-puppet gem (on which we depend on to run tests. I've gotten a fix accepted and merged by the upstream gem but since we use a fork of it, we ned to update our version of it.

Steps to Reproduce

Run ./test.sh

Expected Results

Build runs tests

Actual Results (including error logs, if applicable)

Build fails with following error:

 Failure/Error: require 'puppetlabs_spec_helper/module_spec_helper'
 NameError:
   undefined local variable or method `default_env' for Puppet::Util:Module

Reproducible

Version/Tag number

Current master branch

Environment setup

Both local and CI/CD env can replicate this

Additional Information

Upgrade to latest version may be more advisable than a pure cherry pick to get the latest features.