cyberark / conjur-puppet

Official Puppet module for CyberArk Conjur
https://forge.puppet.com/cyberark/conjur
Apache License 2.0
6 stars 3 forks source link

170 improve unit tests #193

Closed sgnn7 closed 4 years ago

sgnn7 commented 4 years ago

What does this PR do?

What ticket does this PR close?

Connected to #170 Connected to #115

Checklists

Change log

Test coverage

Documentation

izgeri commented 4 years ago

@sgnn7 should these fixes have included change log entries? they seem like benefits to end users:

Adds better UX for certificate parsing issues Fixes escaping for account name during variable fetching

sgnn7 commented 4 years ago

Hmm..yeah that's a good point. we can get those two tacked on the next changelog.