cyberark / conjur-puppet

Official Puppet module for CyberArk Conjur
https://forge.puppet.com/cyberark/conjur
Apache License 2.0
6 stars 3 forks source link

Add code coverage information to builds #194

Closed sgnn7 closed 4 years ago

sgnn7 commented 4 years ago

Is your feature request related to a problem? Please describe.

With switchover to PDK, we should be able to dump the coverage data to our build server

Describe the solution you would like

AC:

Describe alternatives you have considered

N/A

Additional context

N/A

sgnn7 commented 4 years ago

The feature does not seem to work at all using the built-in code coverage tooling in rspec-puppet:

  c.after(:suite) do
    RSpec::Puppet::Coverage.report!
  end 

Results in:

Code coverage                                                                                                                                                                                                                                                                        
  must cover at least 0% of resources                                                                                                                                                                                                                                                
Total resources:   0                                                                                                                                                                                                                                                                 
Touched resources: 0                                                                                                                                                                                                                                                                 
Resource coverage:   NaN%

I'll try to find alternatives to this approach