Use node instead of agent to avoid auto git checkout - Githubissues

cyberark / conjur-puppet

Official Puppet module for CyberArk Conjur

https://forge.puppet.com/cyberark/conjur

Apache License 2.0

6 stars 3 forks source link

Use node instead of agent to avoid auto git checkout #229

Closed hughsaunders closed 3 years ago

hughsaunders commented 3 years ago

What does this PR do?

Removes explicit git tag fetch as Jenkins fetches tags automitcally
Replaces the agent call to allocate a windows node with a node call. This is because agent allocates a node then automatically clones the git repo under test. However git has proven to be unreliable on windows nodes, and only a single file is required from a public repo, so its easy enough to fetch it via http.

What ticket does this PR close?

conjurinc/ops#682

Checklists

Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[x] This PR does not require updating any documentation

hughsaunders commented 3 years ago

5 consecutive green builds:

Screenshot 2020-09-17 at 11 44 57

There were two failed builds before that but that was due to my logic error in the pipeline.