cyberark / conjur-quickstart

Start securing your secrets and infrastructure by installing Conjur, using Docker and the official Conjur containers on DockerHub.
Apache License 2.0
33 stars 36 forks source link

Update docker-compose.yml to handle authenticators #37

Closed szjarek closed 3 years ago

szjarek commented 3 years ago

Ensure that CONJUR_AUTHENTICATORS environment variable is passed to the conjur container. This is required to handle multiple authenticators when using docker.

What does this PR do?

What ticket does this PR close?

Resolves #[relevant GitHub issues, eg 76]

Checklists

Change log

Test coverage

Documentation

izgeri commented 3 years ago

Hey @szjarek - thanks for submitting this. It looks like a reasonable change, but before I approve can you please make sure you've read and understood our contributor agreements? In particular, to accept this contribution I will need you to either amend your commit to include your signoff or for you to sign the contributor agreement. The link I shared has specific instructions for how to amend your git commit - that's the easiest way to move forward.

Thank you! If you have any questions, feel free to ask here or on discourse.

szjarek commented 3 years ago

Hi @izgeri, thank you for your attention! I've some issues with amending this change and didn't want to push a "messy" commit, so I've created another pull request - this time (hopefully) with a proper signoff included. Thanks!