cyberark / conjur-spring-boot-sdk

Apache License 2.0
5 stars 7 forks source link

ByteArray as return secret type #104

Open ghostcky opened 1 year ago

ghostcky commented 1 year ago

Hello, thank you for your contribution and it really helps to integrate with Conjur faster with this library.

I found that previously properties were returned as a String instead of ByteArray. But @asaraogi provided the changes in this commit: https://github.com/cyberark/conjur-spring-boot-sdk/commit/131dfb3238c677b3e495bba04e0465c4a043bb7e. In practice I usually use String type to get a String value but instead of I need to get a ByteArray and convert it by application side or register a new ConversionService for all types which should be supported.

The result of this example returns the byte array as string "49,50,51" instead of "123":

@Configuration
@ConjurPropertySource("spm/v1")
public class ConjurDevConfig
{

  @Value("${DB_USER}")
  private String dbUser;

  ...
}

Could you tell me please what is the reason to use ByteArray and what does "security review change" commit message mean?