I think the name TrustedProxyFilter is subtly inaccurate. A filter is something that takes a list, and returns a sublist (the filtered list) back.
In contrast, this (via the call method) takes a single IP and tells you if it's valid. It's essentially a big configurable function whose input is an IP and whose output is a boolean value. What would you name such a function?
Probably something like valid_ip?. However, since this is a class name (which can't end in ?) I'd consider something like class IsIpValid or class IsIpTrusted.
In client code:
is_trusted = IsIpTrusted.new(...)
if is_trusted(suspicious_ip)
# etc....
micahlee
commented
2 years ago
(copied over on behalf of Jonah):
I think the name
TrustedProxyFilteris subtly inaccurate. A filter is something that takes a list, and returns a sublist (the filtered list) back.In contrast, this (via the
callmethod) takes a single IP and tells you if it's valid. It's essentially a big configurable function whose input is an IP and whose output is a boolean value. What would you name such a function?Probably something like
valid_ip?. However, since this is a class name (which can't end in?) I'd consider something likeclass IsIpValidorclass IsIpTrusted.In client code: