cyberark / conjur

CyberArk Conjur automatically secures secrets used by privileged users and machine identities
https://conjur.org
Other
782 stars 124 forks source link

CNJR-3008 Ensure compose execs specify -T #3000

Closed hughsaunders closed 1 year ago

hughsaunders commented 1 year ago

This is to make sure they are CI-safe and won't attempt to allocate a TTY.

Desired Outcome

Reliable CI builds.

Implemented Changes

Ensure all docker compose invocations specify -T This ensures that docker will not attempt to allocate a TTY when it isn't possible to do so (eg in Jenkins).

Connected Issue/Story

CyberArk internal issue ID: CNJR-3008

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit b69a4c5d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.6% (0.0% change).

View more on Code Climate.

hughsaunders commented 1 year ago

Replaced with: internal pr 41