Closed sigalsax closed 3 years ago
Add some tests. @szamir1 How can we delete cidr ? if we support it we need to test it @szamir1 How many cidr we can write in one command, do we have limitation? we need to test it as well, if we dont have any declaration test with 10 different ip's
@eladkug @sigalsax good questions! what do you mean by delete a cidr? once the restriction is given there is no ability to edit it.
regarding the limitation - I think a limitation is a must, at least for this phase, as I believe it opens a place for problems. Let's set the limitation to 10 CIDRs and add tests accordingly.
What does this PR do?
Add UTs and integration tests for hostfactory 'create token' command
What ticket does this PR close?
Resolves JIRA
Checklists
Change log
Test coverage
Documentation
README
s) were updated in this PR, and/or there is a follow-on issue to update docs, or