CLI should consume sdk code and remove all of the old SDK code from CLI
If you want to test the code locally please view the CONTRIBUTING.md file on how to do so
Hopefully this is the last big PR in this split.
Implemented Changes
Removed SDK code and consume it
ConjurrcData is still cli specific, and inherit from ConjurConnectionInfo from the SDK.
note that this task is to split the repos and should do the minimum effort for this to happen
still maybe it will be better instead of inherit, to create a function ToConjurConnectionInfo. please share your thoughts
Update tests with the sdk mocking
FileCredentialsProvider (netrc) needed to change 'login' to 'username' in the code but in order to not making breaking changes in the file, we still save the file with 'login' as the key
Update of the readme and changelog will be done once this PR approved.
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: [insert issue ID]()
Definition of Done
[ ] pipeline passes with after removing all SDK code
Changelog
[ ] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a
CHANGELOG update
Test coverage
[ ] This PR includes new unit and integration tests to go with the code
changes, or
[ ] The changes in this PR do not require tests
Documentation
[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[ ] This PR does not require updating any documentation
Behavior
[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[ ] No behavior was changed with this PR
Security
[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes
Desired Outcome
CLI should consume sdk code and remove all of the old SDK code from CLI If you want to test the code locally please view the CONTRIBUTING.md file on how to do so Hopefully this is the last big PR in this split.
Implemented Changes
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: [insert issue ID]()
Definition of Done
Changelog
Test coverage
Documentation
READMEs) were updated in this PRBehavior
Security