Use new AuthenticationStrategyInterface - Githubissues

cyberark / cyberark-conjur-cli

CyberArk Conjur command line interface written in Python

https://www.conjur.org

Apache License 2.0

17 stars 16 forks source link

Use new AuthenticationStrategyInterface #410

Closed szh closed 2 years ago

szh commented 2 years ago

Depends on https://github.com/cyberark/conjur-api-python/pull/22

Desired Outcome

Use new AuthenticationStrategy interface created in https://github.com/cyberark/conjur-api-python/pull/20. This lays the groundwork for adding LDAP authentication support.

Implemented Changes

Pass instance of AuthenticationStrategyInterface to Client constructor
Add optional authn_type field to .conjurrc (defaults to authn)

Connected Issue/Story

CyberArk internal issue link: ONYX-20429

Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[x] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[x] There are no security aspects to these changes

szh commented 2 years ago

@cyberark/community-and-integrations-team Can we please get a review on this so we can move forward on #411?