cyberark / kubernetes-conjur-deploy

Scripts for deploying DAP followers to Kubernetes and OpenShift given an existing DAP master cluster
Apache License 2.0
14 stars 15 forks source link

Converted most non-specific CLI usages to kubectl #101

Closed sgnn7 closed 4 years ago

sgnn7 commented 4 years ago

There is no need for most of these tasks to use OC specifically as almost everything can be done with kubectl OOTB. Those things that do not work on kubectl are also now changed from generic $cli to oc.

Note: there is still work to be done here though as none of the $cli create usages have been converted yet.

jtuttle commented 4 years ago

Talked about this in Slack a little but might as well record it here: I think we need to keep the multi-CLI support just in case a customer using OpenShift doesn't have kubectl installed.

I do think we can combine the kubernetes and openshift folders with minimal trouble, though. Pretty sure there's no need to use OpenShift-specific resources there.

sgnn7 commented 4 years ago

I'll close this and switch to work on getting just the yamls fixed up.