make optional password on `oc_login` method - Githubissues

cyberark / kubernetes-conjur-deploy

Scripts for deploying DAP followers to Kubernetes and OpenShift given an existing DAP master cluster

Apache License 2.0

14 stars 15 forks source link

make optional password on `oc_login` method #146

Closed uCatu closed 4 years ago

uCatu commented 4 years ago

Added password as required param to oc_login while users of start ocp 3.11 doesn't require it...

What does this PR do?

What's changed? Why were these changes made?
How should the reviewer approach this PR, especially if manual tests are required?
Are there relevant screenshots you can add to the PR description?

What ticket does this PR close?

Connected to #[relevant GitHub issues, eg 76]

Checklists

Change log

[ ] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[ ] This PR does not require updating any documentation