Change MSSQL repo from Ubuntu to Debian and retry on repo list download failure - Githubissues

cyberark / secretless-broker

Secure your apps by making them Secretless

Apache License 2.0

234 stars 42 forks source link

Change MSSQL repo from Ubuntu to Debian and retry on repo list download failure #1407

Closed imheresamir closed 3 years ago

imheresamir commented 3 years ago

What does this PR do?

Changed MSSQL repo from Ubuntu 16.04 to Debian 10 (Buster), which is more appropriate for the Buster container in which the integration test is run.
Added curl flags to retry the repo list download on error - a maximum of 5 times, 10 second timeout.
HTTP error code will now propagate up to curl return code so CI will stop on error

What ticket does this PR close?

N/A

Checklists

Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[x] This PR does not require updating any documentation, or
[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs

(For releases only) Manual tests

[ ] Manually run Kubernetes-Conjur demo with a local Secretless Broker image build of your branch

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 85aba7e4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.6% (0.0% change).

View more on Code Climate.