Closed szh closed 2 years ago
I'm changing this PR to a draft until cyberark/go-mssqldb#30 is merged in, because I'll have to update the submodule ref.
Builds failing. Appears to be a Red Hat issue. From Jenkins:
[2021-11-01T15:20:36.580Z] Step 24/37 : FROM registry.access.redhat.com/ubi8/ubi as secretless-broker-redhat
[2021-11-01T15:21:57.956Z] received unexpected HTTP status: 503 Service Unavailable
and Github Actions:
Step 24/37 : FROM registry.access.redhat.com/ubi8/ubi as secretless-broker-redhat
received unexpected HTTP status: 504 Gateway Time-out
Builds seem to have been broken by go mod tidy
in go-mssqldb. Rolling that back in https://github.com/cyberark/go-mssqldb/pull/31
Code Climate has analyzed commit 2e520e39 and detected 53 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Style | 53 |
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 54.8% (0.0% change).
View more on Code Climate.
Note to merger: Don't squash commits when merging - "Rebase and merge"
Fixes build failing due to goconvey dependency change. Depends on https://github.com/cyberark/go-mssqldb/pull/30
Desired Outcome
Jenkins builds of Docker images do NOT fail with errors such as the following:
Implemented Changes
go.mod
is upgraded from Go v1.15 to Go v1.16.go env -w GOFLAGS=-mod=mod
is run in containers to fix this module issue in go1.16go mod tidy
to fix build breaking due to this issuebin/codegen
scriptDockerfile.codegen
to use correct upsteamkubernetes/code-generator
repo tag matching K8S packagescontext.TODO()
false positivesConnected Issue/Story
Incidentally resolves #1387
Definition of Done
Changelog
Test coverage
Documentation
README
s) were updated in this PRBehavior
Security