cyberark / secretless-broker

Secure your apps by making them Secretless
Apache License 2.0
234 stars 42 forks source link

Update to Go 1.16 #1434

Closed szh closed 2 years ago

szh commented 2 years ago

Fixes build failing due to goconvey dependency change. Depends on https://github.com/cyberark/go-mssqldb/pull/30

Desired Outcome

Jenkins builds of Docker images do NOT fail with errors such as the following:

[2021-10-26T21:50:18.036Z] #21 1.547 package embed: unrecognized import path "embed": import path does not begin with hostname
[2021-10-26T21:50:26.134Z] #21 8.793 package io/fs: unrecognized import path "io/fs": import path does not begin with hostname
[2021-10-26T21:50:32.671Z] #21 ERROR: executor failed running [/bin/sh -c go get -u github.com/jstemmer/go-junit-report &&     go get github.com/smartystreets/goconvey]: exit code: 1

Implemented Changes

Connected Issue/Story

Incidentally resolves #1387

Definition of Done

Changelog

Test coverage

Documentation

Behavior

Security

szh commented 2 years ago

I'm changing this PR to a draft until cyberark/go-mssqldb#30 is merged in, because I'll have to update the submodule ref.

szh commented 2 years ago

Builds failing. Appears to be a Red Hat issue. From Jenkins:

[2021-11-01T15:20:36.580Z] Step 24/37 : FROM registry.access.redhat.com/ubi8/ubi as secretless-broker-redhat

[2021-11-01T15:21:57.956Z] received unexpected HTTP status: 503 Service Unavailable

and Github Actions:

Step 24/37 : FROM registry.access.redhat.com/ubi8/ubi as secretless-broker-redhat
received unexpected HTTP status: 504 Gateway Time-out
szh commented 2 years ago

Builds seem to have been broken by go mod tidy in go-mssqldb. Rolling that back in https://github.com/cyberark/go-mssqldb/pull/31

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 2e520e39 and detected 53 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 53

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.8% (0.0% change).

View more on Code Climate.

imheresamir commented 2 years ago

Note to merger: Don't squash commits when merging - "Rebase and merge"