pg connector pass client options

doodlesbykumbi commented 2 years ago

pg connector sends all client options in startup message. options specified in secretless config take precendence over those sent by the client

Desired Outcome

Please describe the desired outcome for this PR. Said another way, what was the original request that resulted in these code changes? Feel free to copy this information from the connected issue.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In particular, consider:

What's changed? Why were these changes made?
How should the reviewer approach this PR, especially if manual tests are required?
Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue link: [insert issue ID]()

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

[ ] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[ ] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[ ] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit dd72b317 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Style	2

The test coverage on the diff in this pull request is 40.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.7% (0.0% change).

View more on Code Climate.

alexkalish commented 2 years ago

Internal issue: ONYX-14961.

cyberark / secretless-broker