cyberark / secretless-broker

Secure your apps by making them Secretless
Apache License 2.0
234 stars 42 forks source link

Disable Cobertura autoUpdateStability #1452

Closed john-odonnell closed 2 years ago

john-odonnell commented 2 years ago

This is a temporary change to enable v1.7.10 release.

Desired Outcome

Jenkins build on main are failing due to Codertura line coverage reporting, which is preventing a new release. This PR intends to temporarily lower the minimum line coverage and disable the minimum coverage "ratchet" mechanism.

Implemented Changes

Uses cyberark/secrets-provider-for-k8s#365 as reference:

This change disables the autoUpdateStability and autoUpdateHealth features in Cobertura runs in Jenkins. These features apparently use moving average statistics (not sure of the algorithm used since documentation for these Cobertura plugin features is scarce to nonexistent) over a sliding window of past code coverage results. There's also a "ratchet" mechanism that keeps "raising the bar" for acceptible overall coverage (e.g. starts at 80%, but then can move to 90-95% after several runs).

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue link: [insert issue ID]()

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 5a156e70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.7%.

View more on Code Climate.