Increase Minimum Line Code Coverage Threshold

szh commented 2 years ago

The current code coverage is currently hovering around 65%. Try to get it above 70% and increase the minimum coverage to 70% in the Jenkinsfile.

Min. Coverage: 70%

Desired Coverage: 80%

Optimal Coverage: 90%

Removed empty_test.go files from mock directories, so those directories are not counted towards coverage. This increase combined coverage from UT and integration tests to 68.7%.
Added more unit tests to increase combined coverage to 70.7%.
Modified Jenkinsfile to fail if combined coverage falls below 70%.

CyberArk internal issue link: ONYX-14781

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

[x] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[x] This PR does not require updating any documentation

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[x] There are no security aspects to these changes

adamouamani commented 2 years ago

Looks good

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit be18b295 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 50.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.1% (5.8% change).

View more on Code Climate.

cyberark / secretless-broker