Report combined coverage results to CodeClimate

szh commented 1 year ago

Desired Outcome

After adding code coverage for integration tests and cleanup of false coverage when no tests - code coverage was around 65% with changes from @diverdane and @szh as reflected in Cobertura, but Code Climate still shows about 40%. We are not reporting the merged coverage data to Code Climate.

Implemented Changes

Report combined coverage of unit and integration tests to Code Climate, as we do for Cobertura. To do this, we wait to upload results to Code Climate until after we run the integration tests and combine the coverage data.

Connected Issue/Story

CyberArk internal issue link: ONYX-17825

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[x] There are no security aspects to these changes

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit b0902a7d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.7% (30.6% change).

View more on Code Climate.

adamouamani commented 1 year ago

Thanks @szh - Changes look good to me!

cyberark / secretless-broker