Fix lifecycle hooks in rotation tests - Githubissues

cyberark / secrets-provider-for-k8s

Cyberark secrets provider for k8s

Apache License 2.0

26 stars 11 forks source link

Fix lifecycle hooks in rotation tests #456

Closed szh closed 2 years ago

szh commented 2 years ago

Implemented Changes

Use livenessProbe to restart app container when secrets change. Also fixed integration test yaml that mistakenly had the postStart lifecycle hook in the app container instead of the secrets-provider container.

Connected Issue/Story

N/A

Definition of Done

[ ] CI passes consistently

Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[x] There are no security aspects to these changes

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 9c5ae671 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.2% (0.2% change).

View more on Code Climate.