Fix rotation tests on OpenShift

[szh]

Implemented Changes

• Fixed integration test yaml that mistakenly had the postStart lifecycle hook in the app container instead of the secrets-provider container, and added livenessProbe to restart the app container when secrets change. This should fix testing reliability on OpenShift.

• Also removed the secret deletion portion of the rotation tests in k8s-secrets mode. This test was unreliable because the removal of the secret caused the app container to fail before starting. We would need another way to test this other than checking that the environment variable is cleared. Being that rotation is mainly used with Push-to-File, it may not be worth going through the effort to develop tests for this scenario.

Connected Issue/Story

N/A

Definition of Done

• [x] CI passes consistently (including OCP)

Changelog

• [ ] The CHANGELOG has been updated, or
• [x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

• [ ] This PR includes new unit and integration tests to go with the code changes, or
• [x] The changes in this PR do not require tests

Documentation

• [ ] Docs (e.g. READMEs) were updated in this PR
• [ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
• [x] This PR does not require updating any documentation

Behavior

• [ ] This PR changes product behavior and has been reviewed by a PO, or
• [ ] These changes are part of a larger initiative that will be reviewed later, or
• [x] No behavior was changed with this PR

Security

• [ ] Security architect has reviewed the changes in this PR,
• [ ] These changes are part of a larger initiative with a separate security review, or
• [x] There are no security aspects to these changes

[szh]

LGTM! Should we add a comment or some way to remind us in the future that the secrets deletion is not being tested for k8s secrets mode?

I added a comment here

[codeclimate[bot]]

Code Climate has analyzed commit f8de326e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.0% (0.0% change).

View more on Code Climate.