cyberark / secrets-provider-for-k8s

Cyberark secrets provider for k8s
Apache License 2.0
26 stars 11 forks source link

Fix flaky integration test #487

Closed szh closed 2 years ago

szh commented 2 years ago

Desired Outcome

Fix flaky tests as seen in Jenkins runs 1056 and 1047.

Special thanks to @ismarc for help diagnosing this issue.

Implemented Changes

Removed | head -1 portion of cli_with_timeout command in TEST_ID_26_helm_override_default_retry_successful.sh. This is not necessary because we're not consuming the value at that point, but rather waiting for the value to appear in the logs. It was causing the command to randomly fail when the value wasn't yet in the logs.

Connected Issue/Story

CyberArk internal issue link: ONYX-26380

Changelog

Test coverage

Documentation

Behavior

Security

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit e44695d3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.1% (0.0% change).

View more on Code Climate.