cyberark / secrets-provider-for-k8s

Cyberark secrets provider for k8s
Apache License 2.0
26 stars 11 forks source link

Base64 Secrets Decoding POC #502

Closed gl-johnson closed 1 year ago

gl-johnson commented 1 year ago

Desired Outcome

Please describe the desired outcome for this PR. Said another way, what was the original request that resulted in these code changes? Feel free to copy this information from the connected issue.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In particular, consider:

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

gl-johnson commented 1 year ago

PSA - latest version of the design doc has been moved to a separate PR. Going forward this branch will only contain updates to the POC

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 426c9e12 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 78.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.2% (-0.8% change).

View more on Code Climate.