search

cyberark / summon-aws-secrets

Summon provider for AWS Secrets Manager
MIT License
52 stars 17 forks source link

27 Fix goconvey build failure #28

Closed sgnn7 closed 4 years ago

sgnn7 commented 4 years ago

To support the newest version of goconvey that doesn't break our build, we needed to update our Dockerfile builds to Golang v1.13. Small cleanup of gomod/godep files was done as part of the change.

Fixes #27

izgeri commented 4 years ago

@sgnn7 we might have to revise the changelog message later, FYI. I think it should probably say something at the end like "Please note that since this upgrades the version of golang that we use to build the binaries to 1.13, the binaries generated for releases may not be exactly as before."

but really, we should have tests to capture that so we have some assurance that this project isn't impacted by golang version bumps.

sgnn7 commented 4 years ago

Fair enough - I'll keep that in mind for future work.