Added a build for Apple Silicon

fangel commented 2 years ago

Based on the changes to the main summon .goreleaser.yml file, I've added the same changes to this configuration.

I was able to do a ./bin/build.sh locally, and could manually copy over the result to /usr/local/lib/summon which seems to work.

Note, I've never done any work with either Go or GoReleaser, so this might be the wrong approach. So feel free to suggest a completely different approach to solve the issue of adding support for Apple Silicon.

Desired Outcome

A release for Apple Silicon powered macOS computers to run is created along side all of the existing releases.

Implemented Changes

Took the same approach to modifying the .goreleaser.yml in https://github.com/cyberark/summon/commit/d8e955c7e34c65339a438a9c4626c8231c468fb3

Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[x] There are no security aspects to these changes

rpothier commented 2 years ago

Hi @fangel , thanks for submitting this PR! Can you sign off your commit ? I will run Jenkins to verify the image is built.

fangel commented 2 years ago

I've amended the commit with --signoff and force-pushed now. I think that should fo the trick wrt sign-off.

There's a sister issue at https://github.com/cyberark/homebrew-tools/issues/41 - I can create a PR for the summons-aws-secrets-formulae, but there's still an issue with the way that other non-Apple Silicon formulae in the cask is formulated that makes the whole cask fail.

rpothier commented 2 years ago

Hi @fangel After running the CI I found that the version of Goreleaser that is being used by summon-aws-secrets does not support the new Apple HW. I posted a PR for that . I kept the update as a separate issue in case it breaks any of the current images. That PR should go in first.

fangel commented 2 years ago

Do you want me to rebase off of master, so you can try to re-run the CI builds?

rpothier commented 2 years ago

Hi @fangel , Yes please rebase and can you also add a comment in the changelog?

Added

Added a build for Apple Silicon cyberark/summon-aws-secrets#55

fangel commented 2 years ago

I've rebased off of main and added the changelog modifications now.

fangel commented 2 years ago

Perfect! What's the procedure for actually merging? Will you do that, or?

rpothier commented 2 years ago

Hi @fangel , I merged it. Thanks for submitting this PR!

fangel commented 2 years ago

Wonderful - then the next step for full Apple Silicon support is https://github.com/cyberark/homebrew-tools/issues/41 (and possibly also adding the ARM-build url to the summon-aws-secrets formulae.

cyberark / summon-aws-secrets