fix:tests: sort results of joinEnv for predictability - Githubissues

cyberark / summon

CLI that provides on-demand secrets access for common DevOps tools

https://cyberark.github.io/summon

MIT License

705 stars 63 forks source link

fix:tests: sort results of joinEnv for predictability #195

Closed doodlesbykumbi closed 3 years ago

doodlesbykumbi commented 3 years ago

What does this PR do?

Fix flaky tests by having joinEnv return sorted results.

What ticket does this PR close?

Connected to #193 (not clear if it fully resolves it)

Checklists

Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[x] This PR does not require updating any documentation

doodlesbykumbi commented 3 years ago

@izgeri This func is used to generate the envfile. This change means that the envfile will be sorted by the envvaar names. There's no explicit API that relies on this being sorted or not, so I don't think it needs a CHANGELOG mention. If anything, this sorting is purely for making our code testable.