cyberark / terraform-provider-conjur

Terraform provider for Conjur
https://docs.conjur.org/Latest/en/Content/terraform_Provider.htm
Apache License 2.0
21 stars 16 forks source link

Many provider attributes are not supported #29

Closed jvanderhoof closed 4 years ago

jvanderhoof commented 5 years ago

Issue description

Steps to reproduce the issue

Assumptions

What's the expected result?

What's the actual result?

Dev Notes

In tracking this bug down, I noticed the environment variables mentioned in the readme (ex. export CONJUR_APPLIANCE_URL="https://localhost:8443") are the environment variables the Conjur GoLang library uses. It looks like the convention for setting configuration with environment variables is more like:

Schema: map[string]*schema.Schema{
  "appliance_url": &schema.Schema{
    Type: schema.TypeString,
    Required: true,
    DefaultFunc: schema.EnvDefaultFunc("CONJUR_APPLIANCE_URL", nil),
    Description: "URL of the Conjur Appliance",
  },
  "account": &schema.Schema{
    Type: schema.TypeString,
    Required: true,
    DefaultFunc: schema.EnvDefaultFunc("CONJUR_ACCOUNT", nil),
    Description: "Conjur Account",
  },
  ...
}

which creates a more direct mapping between the environment variables and the provider attributes. Does it make sense to update this technical debt as part of this effort?

sgnn7 commented 4 years ago

Verified this bug - only api_key and login are supported. At the very least we should update the documentation about it.

sgnn7 commented 4 years ago

PR: https://github.com/cyberark/terraform-provider-conjur/pull/59

sgnn7 commented 4 years ago

Released as part of v0.4.0. Closing.