search

cyberbit / modation

Soundation, amplified.
https://cyberbit.github.io/modation
2 stars 2 forks source link

Like a song from the feed #39

Closed cyberbit closed 9 years ago

cyberbit commented 10 years ago

Requested by Xephyr. Perhaps a like button integrated into the player itself?

cyberbit commented 10 years ago

First looks at the UI: image

cyberbit commented 10 years ago

Feedback from Xephyr:

not really [what I had in mind]... that would make every song in my feed take up more space. could you make it so clicking the heart icon acts as a like button?

This will require moving the content script's active pages from the feed page to the track players. This has the advantage of becoming active wherever the player is used throughout the site, instead of just the feed page.

cyberbit commented 10 years ago

@XephyrEntertainment: Played with it a bit, and came up with this UI. The first track is not liked, the second one is. A click on the likes counter likes/unlikes the track. image

XephyrEntertainment commented 10 years ago

perfect! this is a nice little feature, for sure.

On Fri, Oct 24, 2014 at 11:53 PM, D.J. Marcolesco notifications@github.com wrote:

@XephyrEntertainment https://github.com/XephyrEntertainment: Played with it a bit, and came up with this UI. The first track is not liked, the second one is. A click on the likes counter likes/unlikes the track. [image: image] https://cloud.githubusercontent.com/assets/7350183/4778666/e4280198-5bf9-11e4-9e5b-9fd4bceb0eb6.png

— Reply to this email directly or view it on GitHub https://github.com/cyberbit/modation/issues/39#issuecomment-60470625.

cyberbit commented 10 years ago

I was just happy when it worked. :D I'm adding a few more things using this concept, like auto-increment the play counter and a download link.

XephyrEntertainment commented 10 years ago

nice!

On Sat, Oct 25, 2014 at 10:08 AM, D.J. Marcolesco notifications@github.com wrote:

I was just happy when it worked. :D I'm adding a few more things using this concept, like auto-increment the play counter and a download link.

— Reply to this email directly or view it on GitHub https://github.com/cyberbit/modation/issues/39#issuecomment-60484030.

cyberbit commented 9 years ago

Closed by ee2f0e5

cyberbit commented 9 years ago

Removing from Clean Slate, as this is now a built-in feature of the site. How dare you steal my idea! :angry:

XephyrEntertainment commented 9 years ago

;)

On Fri, Jul 17, 2015 at 3:46 PM, D.J. Marcolesco notifications@github.com wrote:

Removing from Clean Slate, as this is now a built-in feature of the site. How dare you steal my idea! [image: :angry:]

— Reply to this email directly or view it on GitHub https://github.com/cyberbit/modation/issues/39#issuecomment-122391736.

cyberbit commented 9 years ago

@XephyrEntertainment I spent a good five days on it, too. :stuck_out_tongue_winking_eye: