cyberbit / modation

Soundation, amplified.
https://cyberbit.github.io/modation
2 stars 2 forks source link

Updated watchlist items can be overwritten #5

Open cyberbit opened 10 years ago

cyberbit commented 10 years ago

If an (Un)watch button is pressed while the watchlist is being checked, the new item is removed from the list.

cyberbit commented 9 years ago

This can also happen if the popup is opened during a check. Perhaps add a system to cancel any queued requests?

cyberbit commented 9 years ago

This should be easily fixable, as CrAPI now sports a storage locking API for updates.

cyberbit commented 8 years ago

Along with the storage locking API, a queue should be implemented. Any watchlist updates will be put in the queue, and before the the watchlist runs, the items will be added and the queue cleared.

cyberbit commented 8 years ago

Unfortunately the storage locking API doesn't work as intended. The contents of localStorage are different in content scripts and do not sync to the extension. UGH.

cyberbit commented 8 years ago

Removing from Watchlist milestone for release.