Closed bananasov closed 2 weeks ago
This is great! Whenever you get to a stopping point I will review in more detail but looks pretty good so far!
The only note I would make is concerning units. For consistency with other adapters I would use B
and B/t
for gas/chemicals/fluids (see below for example from FissionReactorInputAdapter):
Thanks for contributing ❤️
FYI, I found this improved computer API documentation: https://mekanism.github.io/computer_data/10.4.0.html
This is for the very newly released 1.20.x Mekanism version, so it may be slightly off but is probably better than the spreadsheet.
FYI, I found this improved computer API documentation: https://mekanism.github.io/computer_data/10.4.0.html
This is for the very newly released 1.20.x Mekanism version, so it may be slightly off but is probably better than the spreadsheet.
holy shit that is so much better
Hey @Autist69420, are you at a stopping point with this? If so I can merge and continue with the rest of them. :)
Hey @Autist69420, are you at a stopping point with this? If so I can merge and continue with the rest of them. :)
Been a bit lazy lately, you can merge everything I have now if ya want I can always open more PRs :p
although I haven't added everything to the input.lua file yet so 🤷
It happens to the best of us. :)
I will merge everything to feature/more-mekanism
and open another draft PR so progress can still be tracked. I want to take a deeper look at the code and try to define better categories so the standard is the same across Mekanism adapters.
Christ that is a lot of reviews, I'll get to nibbling on them slowly over the week
Merging this for now, as the Mekanism integration is being rewritten with fluent queries.
THIS IS A DRAFT, THERE IS NO WAY IN HELL I'D BE ABLE TO ADD SUPPORT FOR EVERYTHING This PR adds support for even more mekanism inputs!!!! I'd hope to add support for EVERYTHING but currently it is very basic. There are over 700 rows in the CSV im looking up stuff in, its a really bad CSV too, send help.
List of blocks that have support