cyberbotics / epuck_ros2

ROS2 node for the e-puck robot and its simulation model
https://cyberbotics.com/doc/guide/epuck
Apache License 2.0
57 stars 19 forks source link

Initial driver implementation (ImageCompressed, LaserScan, Odometry and Twist) #2

Closed lukicdarkoo closed 4 years ago

lukicdarkoo commented 4 years ago

Description This is the initial pull request that provides ROS2 drivers for pi-puck. It provides a few basic topics, ImageCompressed, LaserScan, Odometry and Twist. It also includes necessary optimisation to run the nodes on Raspberry Pi Zero W smoothly, e.g. GPU utilisation and C++ implementation.

Tasks

omichel commented 4 years ago

:eyes:

lukicdarkoo commented 4 years ago

I would be nice to use the same coding style as in Webots for C, C++ and Python, including line length limitations.

The main changes are introduced in the following two files:

lukicdarkoo commented 4 years ago

Much better this way. There is still a couple of opening brackets that should be fixed (it seems they are not checked by the ROS2 coding style rules).

Yes, package epuck_ros2_camera is not verified by CI because it cannot be built as it depends on Raspberry Pi specific libraries (mmal_*). Maybe we can find a workaround, but for now, I would leave as it is. It is verified manually (with clang-format) in a54ce88.

BTW, it's good we separated camera driver and driver for the rest of e-puck as now we can test them separately.