ShuffleWire
commented
2 years ago I've just look that up, and there is 3 usage of the global variables : (for instance in resources/web/server/session_server.py)
- Reference to "constants" like LOAD_THRESHOLD : using
globalis useless, as global variable/constants could be read from anywhere. moreover sometimes LOAD_THRESHOLD is used without being declaredglobalbefore (which is fine, but not homogeneous with the rest of the code). Is the intend to emphasis the fact that we are using "global" values ? - Reference to object that are being updated, but the reference of the object stay the same : for instance "config" is only updated, hence, as long as we don't change the reference ie
config = ..., it's fine to do stuff likeconfig[...] = ...without needing theglobalkeyword - Variable needing the
globalkeyword, asavailability, modified inupdate_load. Is that a symptom of bad function definition / usage / architecture ? Should we update it ?
To generalize, are there some unspoken rules about it in the Webot code. Do you thing it should be relevant to spend a bit of time to rearrange the code to make those global disappear ? I should be able to do so.
The main question is also about useless global statement to read global variable : removing those global statement will hide the fact that there are global stuff running around. Is that fine ? TBF, it's common in python scripting... And if we don't mess with it (ie don't blindly read/write), it should be fine.
omichel
stefaniapedrazzi
Describe the Bug Some of our python script are usign the
globalkeyword, this is known as a bad practice (see for example: https://docs.quantifiedcode.com/python-anti-patterns/maintainability/using_the_global_statement.html) and can be avoided in 99% of the cases (personally I have never used it and never felt the need to use it):