search

cybercog / laravel-ban

Laravel Ban simplify blocking and banning Eloquent models.
https://komarev.com/sources/laravel-ban
MIT License
1.07k stars 63 forks source link

Allow Laravel 6 #47

Closed JayBizzle closed 5 years ago

antonkomarev commented 5 years ago

Thank you for the contribution @JayBizzle!

I will merge it as soon as v6 will be published to be able to test everything on stable version.

antonkomarev commented 5 years ago

@JayBizzle I've tested Laravel 6 and your changes are not enough. Here is a complete list of required changes which I've made in another package: https://github.com/cybercog/laravel-love/pull/113/files

Need to update orchestra & phpunit packages and add .phpunit.result.cache to .gitignore file.

JayBizzle commented 5 years ago

Thanks @antonkomarev, those changes should now be ready 👍

antonkomarev commented 5 years ago

Test is failing.

I've fixed this issue with --realpath in tests/TestCase.php file when old version of Laravel Love was upgraded.

antonkomarev commented 5 years ago

@JayBizzle thank you for your time. I've merged similar PR which has all the required fixes: #48

JayBizzle commented 5 years ago

No worries 👍