search

cybercog / laravel-eloquent-flag

Laravel Eloquent boolean & timestamp flagged attributes behavior.
https://komarev.com/sources/laravel-eloquent-flag
MIT License
133 stars 21 forks source link

add flag for allow comment both at and is #67

Closed Sivanwol closed 4 years ago

Sivanwol commented 4 years ago

HI i added new flag that i saw that missing that called comment i got a project that need allow comments in a model so this good place put this please note will add more as i see hehe also will mark if the test not pass

antonkomarev commented 4 years ago

What does this flag means?

antonkomarev commented 4 years ago

Name is not obvious. At least it should be named is_commentable, but I'm not sure it's a good place to do the thing. I'd prefer to create separate model which will handle comments of the model, if this model exists - you can add comments to it, otherwise not.

Sivanwol commented 4 years ago

ok about the name done i change at you right it has no sense or more current i got no name sense hehe but the split of modle done sure what u mean

antonkomarev commented 4 years ago

@Sivanwol thank you for the PR, but I'm not ready to add it to this package. As for me it seems wrong way. You could add it in your project.