search

cybercog / laravel-ownership

Laravel Ownership simplify management of Eloquent model's owner.
https://komarev.com/sources/laravel-ownership
MIT License
89 stars 16 forks source link

Total refactoring #21

Open antonkomarev opened 4 years ago

antonkomarev commented 4 years ago

This package requires total refactoring before adding new Laravel versions support and new features.

minitia commented 4 years ago

hi @antonkomarev, what will it breaks if you remove the requirement of laravel 5? Basically they are traits attached to models (I'm not expert in Laravel) Thanks in advance

antonkomarev commented 4 years ago

In theory L6 and L7 support could be added without removing L5 support.

minitia commented 4 years ago

this in you composer "illuminate/database": "~5.2|~5.3|~5.4|~5.5|~5.6|~5.7", "illuminate/support": "~5.2|~5.3|~5.4|~5.5|~5.6|~5.7" doesn't block laravel to v5?

I'm trying to install your branch add-latest-laravel-versions-support

antonkomarev commented 4 years ago

Yes. I haven't added latest Laravel versions because this package was archived for a long time. You could send a PR for the new Laravel versions support.

aaly00 commented 3 years ago

@antonkomarev does the laravel7 branch work with laravel 7, or does the package still need to be updated to laravel7

antonkomarev commented 3 years ago

This package is not working with latest laravel versions. I'm not using it on production anymore. It requires some refactoring.

jny986 commented 3 years ago

Is this package still needed "Total Refactoring" to be an ongoing concern? We are currently getting a "package is abandoned" message when installing the latest version. I am happy to help put with the development that you are wanting to do if we can put together a plan of the development that is needed/wanted. Thanks

antonkomarev commented 3 years ago

@jny986 I've removed abandoned message. Package was updated at the end of the 2020, but I forgot to remove this notice. I don't have plans to continue actively maintaining it by myself, but if you have an ideas how it could be improved - it's always opened for PRs.

aaly00 commented 3 years ago

I don't mind helping with the development as well.> Is this package still needed "Total Refactoring" to be an ongoing concern?

We are currently getting a "package is abandoned" message when installing the latest version.

I am happy to help put with the development that you are wanting to do if we can put together a plan of the development that is needed/wanted.

Thanks

antonkomarev commented 3 years ago

@aaly00 not really, if you are fine with current implementation - we could continue development without changing its architecture and create separate package with the new one requirements when needed. It will be awesome if you will write how are you using this package and what you want to improve.

andrekutianski commented 2 years ago

This package requires total refactoring before adding new Laravel versions support and new features.

Supports Laravel 8/9?

antonkomarev commented 2 years ago

@andrekutianski Laravel 8 is supported. You may provide a PR with Laravel 9 support if you want.