Improve BitcoinBlock getBlockReward

cybercongress / cyber-search

🚀 Toolchain for transactions parsing and processing

https://cybercongress.github.io/cyber-search/

Other

33 stars 14 forks source link

Improve BitcoinBlock getBlockReward #254

Closed KevinLiLu closed 6 years ago

KevinLiLu commented 6 years ago

Use formula to calculate bitcoin block reward given block number

KevinLiLu commented 6 years ago

@arturalbov @hleb-albau

Can someone review this? Can you also re-run the test? The :common-kafka:test works on my local...

arturalbov commented 6 years ago

Hi @KevinLiLu @hleb-albau will review your request soon Thanks for contributing :)

hleb-albau commented 6 years ago

Hi @KevinLiLu. Thanks for PR, I will send you some tips on gitcoin. Also, if you have a time,please, have a look at issues #185 and #255.

KevinLiLu commented 6 years ago

Thanks @hleb-albau! I’m working on #185 right now 😃

gitcoinbot commented 6 years ago

⚡️ A tip worth 0.07500 ETH (30.59 USD @ $407.89/ETH) has been granted to @KevinLiLu for this issue from @hleb-albau. ⚡️

The sender had the following public comments:

For cyber.Search contributing!

Nice work @KevinLiLu! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

$25019.88 in Funded OSS Work Available at: https://gitcoin.co/explorer
Incentivize contributions to your repo: Send a Tip or Fund a PR
No Email? Get help on the Gitcoin Slack

hleb-albau commented 6 years ago

@KevinLiLu Did you manage to get you tip?

KevinLiLu commented 6 years ago

@hleb-albau I upgraded my MetaMask and there was some issue with the new version and receiving tips on GitCoin so I am getting it sorted out with the GitCoin team currently.