Improve test coverage - Githubissues

cyberdelia / atomic

An atomic class that guarantees atomic updates to its contained value.

https://atomic.readthedocs.org

MIT License

24 stars 5 forks source link

Improve test coverage #5

Closed kilink closed 11 years ago

kilink commented 11 years ago

I've improved the tests and test coverage of atomic in a few ways:

Add a few missing test cases.
Extract the Python implementation of Reference into its own module, so that tests can be explicitly run using it.
Set up travis to run the tests on Jython.
Make sure the Java implementation of Reference is used on Jython; I'm not that familiar with Jython, but I had add to update sys.paths for it to be able to find the Java package in com/lapanthere/atomic.

cyberdelia commented 11 years ago

I might to merge it as is, but definitely will merge most of it. Thanks!

cyberdelia commented 11 years ago

Merged in 3ac55c8616be73c140281cb9c382b4f27b15249a.

kilink commented 11 years ago

Hey, thanks for merging some of my changes. I noticed one thing you left out is the modification of sys.path in atomic/init.py (I've commented on the relevant block of code). Maybe I should have opened it as a separate issue, but the Java reference implementation would not load for me under Jython without modifying sys.path.

Maybe I'm doing something wrong, or is that a bug?

cyberdelia commented 11 years ago

I don't really know if we should more use sys.path or good old java CLASSPATH here :expressionless: That's what has hold me back from inserting it for now.