cyberdelia / heroku-geo-buildpack

Geo libraries for Heroku
https://github.com/heroku/heroku-geo-buildpack
113 stars 135 forks source link

Don’t write to .bundle/config #49

Closed schneems closed 6 years ago

schneems commented 6 years ago

Instead or writing to .bundle/config we can instead us the environment variable interface present to define bundler config vars. I wrote about this more here: https://devcenter.heroku.com/articles/bundler-configuration#environment-variable-behavior

This should provide the same behavior as before.

I did notice one issue with the current implementation and that is the values in .bundle/config that are written are the tmp dir paths from build time and not the paths to /app for runtime, though I don’t think it matters, it can’t hurt to fix it.

cyberdelia commented 6 years ago

Thanks Richard :bowtie: :wink:

teeparham commented 6 years ago

Thanks! It take it this was the source of the Heroku deploy warnings about .bundle/config! 👏

schneems commented 6 years ago

Yes, those warnings should be gone now.