search

cyberdelia / metrology

A library to easily measure what's going on in your python.
https://metrology.readthedocs.org
MIT License
309 stars 25 forks source link

graphite reporter. fix socket.sendall mistyping #17

Closed diyan closed 10 years ago

cyberdelia commented 10 years ago

@diyan Could you also fix the tests ? Thanks!

diyan commented 10 years ago

@cyberdelia Sure. Sorry, I have missed that one. I will back with updated pull request in a couple days. Thank you

diyan commented 10 years ago

@cyberdelia I've fixed tests related to Graphite reporter and checked that build was passed on my Travis CI account. Acually you can see this info as well in a pull request.

Thank you for your effort on metrology.

P.S. A bit offtopic question. Do you have any plans to do some integration with existed APIs? For example right now I'm working on Flask integration and also considering work on WSGI middleware and ZeroRPC middleware. I think those integration libraries could be very useful for end users because metrology will be not only a library but also ready-to-use solution.

cyberdelia commented 10 years ago

Awesome, thanks!

I wouldn't be against a generic WSGI middleware, and I would love to see a PR of that, not sure about the other two, considering it could be a maintenance challenge to keep up with both.